Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use var keyword when declaring local variable so it doesn't leak to global scope. #1838

Merged
merged 1 commit into from
Jun 12, 2015
Merged

Use var keyword when declaring local variable so it doesn't leak to global scope. #1838

merged 1 commit into from
Jun 12, 2015

Conversation

trevordixon
Copy link
Contributor

It looks like var was forgotten in a couple places, causing v and style to leak to the global scope.

@sorvell
Copy link
Contributor

sorvell commented Jun 12, 2015

LGTM, Good catch, we'll also add 'use strict'; to avoid this in the future.

sorvell pushed a commit that referenced this pull request Jun 12, 2015
Merge pull request #1838 from trevordixon/patch-1
19758b7 
Use var keyword when declaring local variable so it doesn't leak to global scope.
@sorvell sorvell merged commit 19758b7 into Polymer:master Jun 12, 2015
@trevordixon trevordixon deleted the patch-1 branch June 12, 2015 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trevordixon @sorvell @googlebot